D28134: Add ColorUtils

winterz added a comment. In D28134#643899 , @kossebau wrote: > Seems to no be compatible with Qt 5.12, see failing on CI: https://build.kde.org/view/Failing/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/lastFailedBuild/console same

D28134: Add ColorUtils

dfaure added a comment. Breaks compilation with Qt 5.13 too. /data/kde/src/5/frameworks/kirigami/src/kirigamiplugin.cpp:248:122: error: invalid user-defined conversion from ‘KirigamiPlugin::registerTypes(const char*)::’ to ‘QObject* (*)(QQmlEngine*, QJSEngine*)’ [-fpermissive] 2

D28134: Add ColorUtils

kossebau added a comment. Seems to no be compatible with Qt 5.12, see failing on CI: https://build.kde.org/view/Failing/job/Frameworks/job/kirigami/job/kf5-qt5%20SUSEQt5.12/lastFailedBuild/console REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28134 To: cblack, #p

D28134: Add ColorUtils

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R169:4c7780ea5cf7: Add ColorUtils (authored by cblack). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28134?vs=7952

D28134: Add ColorUtils

mart added a comment. thanks, almost ready to go :) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28134 To: cblack, #plasma, mart, davidedmundson Cc: fvogt, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, mart

D28134: Add ColorUtils

cblack updated this revision to Diff 79525. cblack added a comment. ​ REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=79333&id=79525 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134 AFFECTED FILES CMakeLists.tx

D28134: Add ColorUtils

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > colorutils.h:73 > + */ > +Q_INVOKABLE PendingValue* averageColorForItem(QVariant item, int > maxPixels = 65536); > + *sigh* should be more clear... what

D28134: Add ColorUtils

cblack updated this revision to Diff 79333. cblack added a comment. Rewrite PendingValue to use QFuture REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=79327&id=79333 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D281

D28134: Add ColorUtils

cblack updated this revision to Diff 79327. cblack marked 2 inline comments as done. cblack added a comment. Address issues REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=79097&id=79327 BRANCH cblack/colour-utils REVISION DETAIL https://phab

D28134: Add ColorUtils

fvogt added inline comments. INLINE COMMENTS > colorutils.cpp:90 > +}); > +} > + If item is neither of those three, it would never call `pending->setValue` at all > colorutils.cpp:103 > + > +if (pending->value().isValid()) { > + pending->setValue(luma(result->value().va

D28134: Add ColorUtils

cblack updated this revision to Diff 79097. cblack added a comment. Address feedback REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=78510&id=79097 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134 AFFECTED FILES

D28134: Add ColorUtils

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. still, no item grabbing REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28134 To: cblack, #plasma, mart, davidedmundson Cc: davidedmundson, plasma-devel, fb

D28134: Add ColorUtils

cblack updated this revision to Diff 78510. cblack added a comment. Fix errors REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=78188&id=78510 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134 AFFECTED FILES src/

D28134: Add ColorUtils

cblack added a comment. In D28134#632087 , @davidedmundson wrote: > What's your intended usecase? Generating UI colours from images, icons, etc. and then applying transformations on them to make them more usable. Examples: - Pl

D28134: Add ColorUtils

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. What's your intended usecase? Is Kirigami the right place? The original scope for that was "core application building blocks". INLINE COMMENTS > colorutils.

D28134: Add ColorUtils

cblack updated this revision to Diff 78188. cblack added a comment. Avoid leaving unused connections; effectively removing leaking state related to item grabbing REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=78187&id=78188 BRANCH cblack/colou

D28134: Add ColorUtils

cblack updated this revision to Diff 78187. cblack added a comment. Make brightnessForItem and averageColorForItem take QVariants REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=78069&id=78187 BRANCH cblack/colour-utils REVISION DETAIL https:

D28134: Add ColorUtils

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. please no item grabbing in the singlethon. item grabbing is *not* stateless REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28134 To: cblack, #plasma, mart

D28134: Add ColorUtils

cblack updated this revision to Diff 78069. cblack added a comment. Add linear interpolation, alpha blending, colour adjustment, and colour scaling REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=78030&id=78069 BRANCH cblack/colour-utils REVIS

D28134: Add ColorUtils

cblack updated this revision to Diff 78030. cblack added a comment. Asynchronous return values REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=77976&id=78030 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134 AFFEC

D28134: Add ColorUtils

mart added a comment. First of all.. I love the idea! :) I wanted something like that, tough i had a slightly different approach.. i find the global average color usually producing a kinda washed down color (from what happens in the plasma mobile app startup screen) For another proj

D28134: Add ColorUtils

cblack updated this revision to Diff 77976. cblack added a comment. Improve documentation comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=77975&id=77976 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134 A

D28134: Add ColorUtils

cblack updated this revision to Diff 77975. cblack added a comment. Better class description REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=77974&id=77975 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134 AFFECTE

D28134: Add ColorUtils

cblack updated this revision to Diff 77974. cblack added a comment. Add comments to code REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=77973&id=77974 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134 AFFECTED FI

D28134: Add ColorUtils

cblack updated this revision to Diff 77973. cblack added a comment. Use words instead of single letters REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=77972&id=77973 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D281

D28134: Add ColorUtils

cblack updated this revision to Diff 77972. cblack added a comment. Add EOF newlines REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28134?vs=77971&id=77972 BRANCH cblack/colour-utils REVISION DETAIL https://phabricator.kde.org/D28134 AFFECTED FILES

D28134: Add ColorUtils

cblack created this revision. cblack added reviewers: Plasma, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY ColorUtils is a class that offers utilities for working with colour, offering the following i