mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > colorutils.h:73 > + */ > + Q_INVOKABLE PendingValue* averageColorForItem(QVariant item, int > maxPixels = 65536); > + *sigh* should be more clear... what i don't want in a singleton type, and i'm not going to accept until is there, is this whole grabbing of items. in a singleton like that, i would want uniquely small, stateless and sync functions that take QColors as input and have qcolors (or any other simple value lile ints and what not) as output, nothing else REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28134 To: cblack, #plasma, mart, davidedmundson Cc: fvogt, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, mart
