D28099: Show command output on unknown failure

2020-03-17 Thread Ivan Čukić
This revision was automatically updated to reflect the committed changes. Closed by commit R845:1e2988d7d3ca: Show command output on unknown failure (authored by ivan). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28099?vs=77828&id=77836 REVISION DETAI

D28099: Show command output on unknown failure

2020-03-17 Thread Ivan Čukić
ivan updated this revision to Diff 77828. REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28099?vs=77822&id=77828 REVISION DETAIL https://phabricator.kde.org/D28099 AFFECTED FILES .gitignore kded/engine/backends/cryfs/cryfsbackend.cpp kded/engine/

D28099: Show command output on unknown failure

2020-03-17 Thread Ivan Čukić
ivan added a comment. Of course... I need to reboot my brain it seems. REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D28099 To: ivan, #plasma, davidedmundson, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampal

D28099: Show command output on unknown failure

2020-03-17 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > mountdialog.cpp:57 > + > +QMessageBox::critical(this, i18n("Error details"), message); > + Kded is one of the processes that shouldn't freeze, lets avoid nested event loops Some sort of box = new QMessageBox() box->setWid

D28099: Show command output on unknown failure

2020-03-17 Thread Ivan Čukić
ivan created this revision. ivan added reviewers: Plasma, davidedmundson, ngraham, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ivan requested review of this revision. REVISION SUMMARY If the error is unknown (all errors in encfs), show the 'details...' button