davidedmundson added inline comments.

INLINE COMMENTS

> mountdialog.cpp:57
> +
> +                QMessageBox::critical(this, i18n("Error details"), message);
> +

Kded is one of the processes that shouldn't freeze, lets avoid nested event 
loops

Some sort of

box = new QMessageBox()
box->setWidgetAttribute(delete on close)
box->show();

would be preferred

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D28099

To: ivan, #plasma, davidedmundson, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to