D27782: expose IncludeUsage to QML api

2020-03-03 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R120:0775faf25323: expose IncludeUsage to QML api (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27782?vs=76774&id=76835 REVISION DETAIL

D27782: expose IncludeUsage to QML api

2020-03-02 Thread Marco Martin
mart updated this revision to Diff 76774. mart added a comment. - rename property to shownItems REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27782?vs=76768&id=76774 BRANCH phab/exposeusage REVISION DETAIL https://phabricator.kde.org/D27782

D27782: expose IncludeUsage to QML api

2020-03-02 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in recentusagemodel.cpp:150 > we have QQmlParserStatus in this class, we probably want to use it. refresh() implementation already has a check on m_completed (which is set on componentCompleted) REPOSITORY R120 Plasma Workspa

D27782: expose IncludeUsage to QML api

2020-03-02 Thread David Edmundson
davidedmundson added a comment. generally makes sense INLINE COMMENTS > recentusagemodel.cpp:150 > +emit usageChanged(); > +refresh(); > +} we have QQmlParserStatus in this class, we probably want to use it. > recentusagemodel.h:69 > Q_PROPERTY(int ordering READ ordering WRITE

D27782: expose IncludeUsage to QML api

2020-03-02 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY RecentUsageModel can list all aps and docs, only aps or only docs. make possible to control that from QML