davidedmundson added a comment.
generally makes sense INLINE COMMENTS > recentusagemodel.cpp:150 > + emit usageChanged(); > + refresh(); > +} we have QQmlParserStatus in this class, we probably want to use it. > recentusagemodel.h:69 > Q_PROPERTY(int ordering READ ordering WRITE setOrdering NOTIFY > orderingChanged) > + Q_PROPERTY(IncludeUsage usage READ usage WRITE setUsage NOTIFY > usageChanged) > Can we pick something a bit more specific. Everything fits under "usage" REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27782 To: mart, #plasma Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
