This revision was automatically updated to reflect the committed changes.
Closed by commit R169:26f942fc335f: Fix ActionToolBar/PrivateActionToolButton
in combination with QQC2 Action (authored by ahiemstra).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D276
ahiemstra added inline comments.
INLINE COMMENTS
> ognarb wrote in ActionToolBarLayoutDetails.qml:126
> I think this can be simplified to
>
> return !modelData.hasOwnProperty("displayHint") ||
> !modelData.displayHintSet(Kirigami.Action.DisplayHint.AlwaysHide;
The reason I'm expanding these
camiloh added a comment.
works okay for me with qqc2 actions
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D27653
To: ahiemstra, #kirigami
Cc: camiloh, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,
ngraham, apol, ahiemstra, davidedmundson, mart, h
ognarb added inline comments.
INLINE COMMENTS
> ActionToolBarLayoutDetails.qml:126
> +
> +if (modelData.hasOwnProperty("displayHint") &&
> +
> modelData.displayHintSet(Kirigami.Action.DisplayHint.AlwaysHide)) {
I think this can be simplified to
retu
ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.
REVISION SUMMARY
This applies a few fixes to ActionToolBar and PrivateActionToolButton when
used in com
