ahiemstra added inline comments.
INLINE COMMENTS
> ognarb wrote in ActionToolBarLayoutDetails.qml:126
> I think this can be simplified to
>
> return !modelData.hasOwnProperty("displayHint") ||
> !modelData.displayHintSet(Kirigami.Action.DisplayHint.AlwaysHide;
The reason I'm expanding these in the first place is for readability, I keep
finding the simplified forms hard to read as soon as there's more than one
check involved. So I would rather not simplify this, as now the logic is very
explicit and does not need a lot of mental parsing to figure out what is going
on.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D27653
To: ahiemstra, #kirigami
Cc: camiloh, ognarb, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,
ngraham, apol, ahiemstra, davidedmundson, mart, hein
