broulik added inline comments.
INLINE COMMENTS
> broulik wrote in ActionItem.cpp:143
> Don't iterate `values()`, which creates a temporary list, instead use
> iterators.
Ok, probably not, since this is a `QHash` with `insertMulti`...
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://
broulik added inline comments.
INLINE COMMENTS
> ActionItem.cpp:143
> if (actionType == ActionItem::DesktopRead) {
> -foreach(KConfigGroup * possibleGroup, actionGroups.values(keyGroup))
> {
> +const auto values = actionGroups.values(keyGroup);
> +for (KConfigGroup *
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5bb3ebc94d82: KCM/solid-actions convert foreach (authored
by meven).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27154?vs=74995&id=74996
REVISION DETAIL
meven updated this revision to Diff 74995.
meven added a comment.
Add a missing space
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D27154?vs=74993&id=74995
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27154
AFFECTED FILES
kcms
meven created this revision.
meven added reviewers: ervin, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D27154
AFFECTED FIL
