broulik added inline comments.
INLINE COMMENTS
> ActionItem.cpp:143
> if (actionType == ActionItem::DesktopRead) {
> - foreach(KConfigGroup * possibleGroup, actionGroups.values(keyGroup))
> {
> + const auto values = actionGroups.values(keyGroup);
> + for (KConfigGroup *possibleGroup : values) {
Don't iterate `values()`, which creates a temporary list, instead use iterators.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27154
To: meven, ervin, #plasma, davidedmundson
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
