D27142: Have authhelper define config file paths on its own

2020-02-09 Thread Filip Fila
This revision was automatically updated to reflect the committed changes. Closed by commit R123:c4b41ffe6660: Have authhelper define config file paths on its own (authored by filipf). REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27142?

D27142: Have authhelper define config file paths on its own

2020-02-05 Thread David Edmundson
davidedmundson added a comment. Yes REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH decoupled-config-path (branched from master) REVISION DETAIL https://phabricator.kde.org/D27142 To: filipf, #plasma, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, j

D27142: Have authhelper define config file paths on its own

2020-02-05 Thread Filip Fila
filipf added a comment. 5.18 then, right? REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH decoupled-config-path (branched from master) REVISION DETAIL https://phabricator.kde.org/D27142 To: filipf, #plasma, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cbl

D27142: Have authhelper define config file paths on its own

2020-02-04 Thread Filip Fila
filipf updated this revision to Diff 75005. filipf added a comment. undo changes for mSddmConfig and kill mSddmOldConfig REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27142?vs=74955&id=75005 BRANCH decoupled-config-path (branched

D27142: Have authhelper define config file paths on its own

2020-02-04 Thread David Edmundson
davidedmundson added a comment. oh, then kill it REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D27142 To: filipf, #plasma, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragr

D27142: Have authhelper define config file paths on its own

2020-02-04 Thread Filip Fila
filipf added a comment. In D27142#605960 , @davidedmundson wrote: > I dunno, what is it? something I added before because I thought the `/etc/sddm.conf.d/kde_settings.conf` path should also be specified here. That was to be `mSddmConfig

D27142: Have authhelper define config file paths on its own

2020-02-04 Thread David Edmundson
davidedmundson added a comment. I dunno, what is it? REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D27142 To: filipf, #plasma, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D27142: Have authhelper define config file paths on its own

2020-02-04 Thread Filip Fila
filipf added inline comments. INLINE COMMENTS > davidedmundson wrote in sddmkcm.cpp:55 > I don't think this is right. > > This file is added below: > > systemConfigFiles = > QDir(QLatin1String(SDDM_SYSTEM_CONFIG_DIR)).entryList(QDir::Files | > QDir::NoDotAndDotDot, QDir::LocaleAware); > >

D27142: Have authhelper define config file paths on its own

2020-02-03 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > sddmkcm.cpp:55 > > -mSddmConfig = > KSharedConfig::openConfig(QStringLiteral(SDDM_CONFIG_FILE), > KConfig::CascadeConfig); > +mSddmConfig = KSharedConfig::openConfig(QString > {QLatin1String(SDDM_CONFIG_DIR "/") + QStringLiteral

D27142: Have authhelper

2020-02-03 Thread Filip Fila
filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Suggested for D26813 . Prerequiste if user-manager is to not send any SDDM config file path on it