davidedmundson added inline comments.

INLINE COMMENTS

> sddmkcm.cpp:55
>  
> -    mSddmConfig = 
> KSharedConfig::openConfig(QStringLiteral(SDDM_CONFIG_FILE), 
> KConfig::CascadeConfig);
> +    mSddmConfig = KSharedConfig::openConfig(QString 
> {QLatin1String(SDDM_CONFIG_DIR "/") + QStringLiteral("kde_settings.conf")}, 
> KConfig::CascadeConfig);
>  

I don't think this is right.

This file is added below:

  systemConfigFiles = 
QDir(QLatin1String(SDDM_SYSTEM_CONFIG_DIR)).entryList(QDir::Files | 
QDir::NoDotAndDotDot, QDir::LocaleAware);

loops through every file in /etc/sddm.conf.d

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27142

To: filipf, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to