D26217: Add standard pen widths and replace hardcoded numbers

This revision was automatically updated to reflect the committed changes. Closed by commit R31:c16eb7a4614f: Add standard pen widths and replace hardcoded numbers (authored by ndavis). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26217?vs=72270&id=72271 REVIS

D26217: Add standard pen widths and replace hardcoded numbers

ndavis updated this revision to Diff 72270. ndavis marked 2 inline comments as done. ndavis added a comment. Change symbol pen width back to 1.1 REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26217?vs=72223&id=72270 BRANCH replace-hardcoded (branched from

D26217: Add standard pen widths and replace hardcoded numbers

ndavis marked an inline comment as done. ndavis added inline comments. INLINE COMMENTS > hpereiradacosta wrote in breeze.h:180 > For the record, //* (and /**) should also be caught by Doxygen (and hopefully > KDevelop). It is used more or less systematically in oxygen, so please use > this inst

D26217: Add standard pen widths and replace hardcoded numbers

hpereiradacosta accepted this revision. hpereiradacosta added a comment. looks good. See comment about the symbol pen width change and then ship it. In D26217#583358 , @ngraham wrote: > ...And after these patches land, let's do the doxygen-fr

D26217: Add standard pen widths and replace hardcoded numbers

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. ...And after these patches land, let's do the doxygen-friendly comment formatting all at once in another patch. REPOSITORY R31 Breeze BRANCH replace-hardcoded (branched from master)

D26217: Add standard pen widths and replace hardcoded numbers

ndavis updated this revision to Diff 72223. ndavis added a comment. Change comment formatting REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26217?vs=72157&id=72223 BRANCH replace-hardcoded (branched from master) REVISION DETAIL https://phabricator.kde.

D26217: Add standard pen widths and replace hardcoded numbers

ngraham added inline comments. INLINE COMMENTS > ndavis wrote in breeze.h:179 > It's a Doxygen style. If you do it, KDevelop shows the comments in the > tooltips for the commented functions, classes and variables. Probably makes sense to do this universally all at once, rather than in little b

D26217: Add standard pen widths and replace hardcoded numbers

ndavis added inline comments. INLINE COMMENTS > ngraham wrote in breeze.h:179 > Why three slashes for these comments? It's a Doxygen style. If you do it, KDevelop shows the comments in the tooltips for the commented functions, classes and variables. REPOSITORY R31 Breeze REVISION DETAIL h

D26217: Add standard pen widths and replace hardcoded numbers

ngraham added a comment. +1, seems sensible to me, but probably wait for @hpereiradacosta's go-ahead. INLINE COMMENTS > breeze.h:179 > + */ > +/// The standard pen stroke width for symbols. > +static constexpr qreal Symbol = 1.01; Why three slashes for these comments?

D26217: Add standard pen widths and replace hardcoded numbers

ndavis created this revision. ndavis added reviewers: Breeze, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY The replaced numbers are directly related to the width of the pen. This patch likely doesn't