ndavis marked an inline comment as done. ndavis added inline comments. INLINE COMMENTS
> hpereiradacosta wrote in breeze.h:180 > For the record, //* (and /**) should also be caught by Doxygen (and hopefully > KDevelop). It is used more or less systematically in oxygen, so please use > this instead of /// OK. KDevelop won't always detect comments that use other doxygen styles or display them correctly, but that's a KDevelop problem, not a Breeze code problem. > hpereiradacosta wrote in breezehelper.cpp:1355 > Here the penwidth is actually changed (from 1.1 to 1.01) this could affect > the appearance of the actual buttons. Are you happy with the new appearance ? > Also, should doublecheck that this is consistent with button rendering in the > decoration. > > In fact for the sake of changing only one thing at a time, I would set > penwidth::Symbol to 1.1 Yes, 1.01 works fine. 1.1 is slightly visible when scaling up the UI, so I changed it. I had planned to do the KDecoration after this patch. I will put the width change in a different commit though. REPOSITORY R31 Breeze BRANCH replace-hardcoded (branched from master) REVISION DETAIL https://phabricator.kde.org/D26217 To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
