D26185: Fix font rendering when compiled against Qt >= 5.14

davidedmundson added a comment. Ack. Thanks for chasing up on indentifying causes. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma, apol, davidedmundson Cc: acooligan, fvogt, asturmlechner, dfaure, davidedmundson, anthonyfieroni,

D26185: Fix font rendering when compiled against Qt >= 5.14

fvogt added a comment. The change itself is correct, but not in relation to the title and summary which are about https://bugreports.qt.io/browse/QTBUG-80967, which was a genuine bug in Qt, fixed in 5.14.1. What this change fixes is double scaling in applications which enable `Qt::AA_Enabl

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. So what do we do here? The Qt bug has been fixed but still I'm not sure what should be done about the environment variables. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma, apol, davidedmundson Cc: ac

D26185: Fix font rendering when compiled against Qt >= 5.14

acooligan added a comment. I think you may leave ifdef here but set: qputenv("QT_ENABLE_HIGHDPI_SCALING", "0"); if it's false as `QT_AUTO_SCREEN_SCALE_FACTOR` is deprecated since qt 5.14. In D26185#582742 , @davidedmundson wrote:

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. In D26185#584249 , @davidedmundson wrote: > Thanks for following up! > > > I'll open a Qt bug and see how it goes. > > Can you link it please. Somebody was faster. I added a comment and a link to this di

D26185: Fix font rendering when compiled against Qt >= 5.14

davidedmundson added a comment. Thanks for following up! > I'll open a Qt bug and see how it goes. Can you link it please. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma, apol, davidedmundson Cc: asturmlechner, dfaure,

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. In D26185#583991 , @anthonyfieroni wrote: > Can forcing bigger font DPI make things better? AFAICS no. If scaling is conceptually enabled, i.e. if an application //would// be scaled //if// you attached a high D

D26185: Fix font rendering when compiled against Qt >= 5.14

anthonyfieroni added a comment. Can forcing bigger font DPI make things better? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma, apol, davidedmundson Cc: asturmlechner, dfaure, davidedmundson, anthonyfieroni, plasma-devel, LeGas

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. It's probably okay to still say that scaling is enabled "in general" but for scaling <2, and why not, maybe even greater, hinting should not be inhibited. The screen is still made of pixels. Qt is not going to be able to throw out all the hinting and subpixel code

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. I think I see the problem. You pay for the //possibility// to have scaling with unhinted fonts. I am pretty sure that that isn't an acceptable way of handling it. Most Linux desktop fonts are intended to be used with some hinting (slight hinting usually?). QHighDpi

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. Just to make this extra clear, I have nothing against auto-scaling. There is probably a KCM to set it however I want if I don't like the default. My problem is with blurry and in some cases ("-=") disfigured font rendering. That should never happen regardless of ph

D26185: Fix font rendering when compiled against Qt >= 5.14

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. After 900f2cb6f7070 in QtBase auto dpi changed it's meaning somewhat. The comment written no longer applies and #ifdef'ing is the correct thing to get the consiste

D26185: Fix font rendering when compiled against Qt >= 5.14

apol added subscribers: davidedmundson, dfaure. apol added a comment. I'm not all that sure. Not it's coming from D24255 by @dfaure, approved by @davidedmundson. Maybe they have some insight. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://p

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. In D26185#582095 , @anthonyfieroni wrote: > Test with `qputenv(QT_ENABLE_HIGHDPI_SCALING, "1")` it's especially for 5.14+ That unfortunately does not seem to help. I set the environment in a shell inside konso

D26185: Fix font rendering when compiled against Qt >= 5.14

anthonyfieroni added a comment. Test with `qputenv(QT_ENABLE_HIGHDPI_SCALING, "1")` it's especially for 5.14+ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma Cc: anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz added a comment. Compiled against Qt 5.14 before this change: F7832282: before.png Compiled against Qt 5.14 after this change: F7832284: after.png REPOSITORY R120 Plasma Workspace REVISION DETAI

D26185: Fix font rendering when compiled against Qt >= 5.14

ahartmetz created this revision. ahartmetz added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahartmetz requested review of this revision. REVISION SUMMARY Whatever behavior change was apparently expected in Qt 5.14 didn't happen. I compiled again