davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed.
After 900f2cb6f7070 in QtBase auto dpi changed it's meaning somewhat. The comment written no longer applies and #ifdef'ing is the correct thing to get the consistent behaviour. With QT_AUTO_SCREEN_SCALE_FACTOR=0 set, we no longer scale the logical DPI by the screen scale factor which is something we need to deliver high DPI correctly. i.e on a low res screen with a physical of 96, running QT_SCREEN_SCALE_FACTORS=2 should double the fonts. This patch breaks that which means we've broken the config UI. There may well be some changes needed, but this on its own isn't it. Relevant code to look through is qhighdpi.cpp in QtBase REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26185 To: ahartmetz, #plasma, apol, davidedmundson Cc: asturmlechner, dfaure, davidedmundson, anthonyfieroni, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
