D26026: refactor: let Control be a QObject

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R104:e5abdd26fd27: refactor: let Control be a QObject (authored by romangg). CHANGED PRIOR TO COMMIT https://phabricator.

D26026: refactor: let Control be a QObject

romangg marked 2 inline comments as done. romangg added a comment. I move forward with this approach and revisit later to work on a better solution. Maybe with the libkscreen dbus process. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D26026 To: romangg, #plasma Cc

D26026: refactor: let Control be a QObject

romangg added inline comments. INLINE COMMENTS > config.cpp:45 > +, m_data(config) > +, m_control(new ControlConfig(config, this)) > { Caching it means we don't read in new retention value when it changed. So this patch without a file watcher yet or other system to communicate changes

D26026: refactor: let Control be a QObject

romangg added a comment. That being said thinking about it some more having a file watcher can lead to races for example in the following case: - User changes auto rotation and resolution at the same time while device is held in a position unequal to current rotation - KWin receives up

D26026: refactor: let Control be a QObject

romangg added a comment. In D26026#578484 , @davidedmundson wrote: > > This is a preparatory step to add signals later for watching file changes. > > I don't think I understand. What for? > If it's full output configuration going via the

D26026: refactor: let Control be a QObject

davidedmundson added a comment. > This is a preparatory step to add signals later for watching file changes. I don't think I understand. What for? If it's full output configuration going via the disk that would go against the main part of kscreen architecture. INLINE COMMENTS > contr

D26026: refactor: let Control be a QObject

romangg created this revision. romangg added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. romangg requested review of this revision. REVISION SUMMARY This is a preparatory step to add signals later for watching file changes. TEST PLAN Tested in