romangg added inline comments.

INLINE COMMENTS

> config.cpp:45
> +    , m_data(config)
> +    , m_control(new ControlConfig(config, this))
>  {

Caching it means we don't read in new retention value when it changed. So this 
patch without a file watcher yet or other system to communicate changes breaks 
the runtime. Solution without it: do not cache but in `writeFile` always create 
new object for now.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D26026

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to