D24283: Add clang format file

cullmann added a comment. There will anyways be one "big" change in the history, but normally git will be able to handle that well by ignoring space changes for blame or diff. I don't think without the aligning the change will be much smaller. REPOSITORY R120 Plasma Workspace REVISION DE

D24283: Add clang format file

zzag added a comment. In D24283#545620 , @cullmann wrote: > For the alignment of comments, I am not sure, it makes the stuff a lot more readable in many cases and after the initial re-format you don't have a lot of jitter normally. As I

D24283: Add clang format file

cullmann added inline comments. INLINE COMMENTS > zzag wrote in .clang-format:83 > s/coding/coding style/ Fixed that in D24568 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24283 To: davidedmundson Cc: zzag, cullmann, pl

D24283: Add clang format file

davidedmundson abandoned this revision. davidedmundson added a comment. Lets do all this discussion on D24568 However, as this CC's the plasma team I would urge people again to follow up on that thread as I do intend on running it across all plasma rep

D24283: Add clang format file

cullmann added a comment. This is just a base file for discussion. Stuff like the mentioned case indentation can be adjusted to be frameworks conform. For the alignment of comments, I am not sure, it makes the stuff a lot more readable in many cases and after the initial re-format you don

D24283: Add clang format file

zzag added inline comments. INLINE COMMENTS > zzag wrote in .clang-format:83 > The Frameworks coding says not to indent case lables. s/coding/coding style/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24283 To: davidedmundson Cc: zzag, cullmann, plasma-dev

D24283: Add clang format file

zzag added inline comments. INLINE COMMENTS > .clang-format:55-56 > + > +# align trailing comments > +AlignTrailingComments: true > + I'd object to aligning trailing comments because a single line change may affect many other unrelated lines. However, if this .clang-format file serves just as

D24283: Add clang format file

cullmann added a comment. See D24568 for the draft of an ECM module that applies the Kate/KTextEditor/Artikulate style. Is the same file as here, with sorting of includes, but with column limit. REPOSITORY R120 Plasma Workspace REVISION DETAIL https

D24283: Add clang format file

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Kate have just clang-formatted all their code, a few other proejcts have too (see T11214