zzag added inline comments.

INLINE COMMENTS

> .clang-format:55-56
> +
> +# align trailing comments
> +AlignTrailingComments: true
> +

I'd object to aligning trailing comments because a single line change may 
affect many other unrelated lines.

However, if this .clang-format file serves just as a sample and projects are 
allowed to tweak it, then it's fine.

> .clang-format:83
> +# indent case labels one level
> +IndentCaseLabels: true
> +

The Frameworks coding says not to indent case lables.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24283

To: davidedmundson
Cc: zzag, cullmann, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to