D24147: fix compatibility with Qt5.11

2019-09-24 Thread Matthieu Gallien
This revision was automatically updated to reflect the committed changes. Closed by commit R169:d2570246a555: fix compatibility with Qt5.11 (authored by mgallien). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24147?vs=6&id=66764 REVISION DETAIL https

D24147: fix compatibility with Qt5.11

2019-09-23 Thread Matthieu Gallien
mgallien added inline comments. INLINE COMMENTS > broulik wrote in ActionToolBar.qml:173 > I don't think you can replace arrow functions by a simple assignment. Isn't > this just a hack to turn that list into an `Array`? Thanks for the review. I was ignorant of arrow functions. The new version

D24147: fix compatibility with Qt5.11

2019-09-23 Thread Matthieu Gallien
mgallien updated this revision to Diff 6. mgallien added a comment. correct modifications from arrow function to a simple short one REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24147?vs=66627&id=6 BRANCH master REVISION DETAIL https://phabr

D24147: fix compatibility with Qt5.11

2019-09-23 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > ActionToolBar.qml:173 > icon.name: "overflow-menu" > -children: Array.prototype.map.call(root.actions, i => > i).concat(Array.prototype.map.call(hiddenActions, i => i)) > +children: Array.prototype.

D24147: fix compatibility with Qt5.11

2019-09-22 Thread Matthieu Gallien
mgallien added a comment. It has been reported in debian https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=940939 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D24147 To: mgallien, #kirigami Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, davided

D24147: fix compatibility with Qt5.11

2019-09-22 Thread Matthieu Gallien
mgallien created this revision. mgallien added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mgallien requested review of this revision. REVISION SUMMARY Kirigami2 requires Qt 5.11 but D22974 broke that prom