broulik added inline comments.

INLINE COMMENTS

> ActionToolBar.qml:173
>                  icon.name: "overflow-menu"
> -                children: Array.prototype.map.call(root.actions, i => 
> i).concat(Array.prototype.map.call(hiddenActions, i => i))
> +                children: Array.prototype.map.call(root.actions, i = 
> i).concat(Array.prototype.map.call(hiddenActions, i = i))
>              }

I don't think you can replace arrow functions by a simple assignment. Isn't 
this just a hack to turn that list into an `Array`?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24147

To: mgallien, #kirigami
Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

Reply via email to