D23287: Create a plugin framework for processes

2019-09-13 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R111:064688415a1e: Create a plugin framework for processes (authored by davidedmundson). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=65997&id=65998

D23287: Create a plugin framework for processes

2019-09-13 Thread Méven Car
meven accepted this revision. meven added a comment. Build with QT 5.12 REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D23287 To: davidedmundson, #plasma, ahiemstra, meven Cc: meven, zzag, ahiemstra, alexde, broulik, plasma-devel, LeGast00n

D23287: Create a plugin framework for processes

2019-09-13 Thread David Edmundson
davidedmundson updated this revision to Diff 65997. davidedmundson added a comment. update REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=65993&id=65997 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23287 AFFECTED FILE

D23287: Create a plugin framework for processes

2019-09-13 Thread David Edmundson
davidedmundson updated this revision to Diff 65993. davidedmundson added a comment. Rebase, add include REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64404&id=65993 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23287

D23287: Create a plugin framework for processes

2019-08-31 Thread Méven Car
meven added inline comments. INLINE COMMENTS > process_data_provider.cpp:23 > +#include "process_attribute.h" > + > +using namespace KSysGuard; Missing `#include ` Results in build error : kde/src/libksysguard/processcore/process_data_provider.cpp:30:33: error: field ‘m_attributes’ has inco

D23287: Create a plugin framework for processes

2019-08-23 Thread David Edmundson
davidedmundson updated this revision to Diff 64404. davidedmundson added a comment. q_decl_hidden ran clang-format over new files REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64291&id=64404 BRANCH master REVISION DETAIL https://

D23287: Create a plugin framework for processes

2019-08-23 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > extended_process_list.cpp:31 > + > +class ExtendedProcesses::Private > +{ Symbol of the PIMPL is leaked. Use Q_DECL_HIDDEN. > process_data_provider.h:42-52 > +/** > + * Accessors for process information matching > + */ > +KSysGuard::

D23287: Create a plugin framework for processes

2019-08-22 Thread David Edmundson
davidedmundson updated this revision to Diff 64291. davidedmundson added a comment. Split ProcessAttribute into a new file Install headers correctly REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64189&id=64291 BRANCH master REVISIO

D23287: Create a plugin framework for processes

2019-08-21 Thread David Edmundson
davidedmundson updated this revision to Diff 64189. davidedmundson added a comment. update REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64155&id=64189 REVISION DETAIL https://phabricator.kde.org/D23287 AFFECTED FILES processcore/C

D23287: Create a plugin framework for processes

2019-08-21 Thread Arjen Hiemstra
ahiemstra requested changes to this revision. ahiemstra added a comment. This revision now requires changes to proceed. Just a few small things I came across when working on the network plugin. INLINE COMMENTS > extended_process_list.cpp:82 > +for (auto plugin: pluginObjects) { > +

D23287: Create a plugin framework for processes

2019-08-20 Thread David Edmundson
davidedmundson updated this revision to Diff 64155. davidedmundson added a comment. update REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64136&id=64155 REVISION DETAIL https://phabricator.kde.org/D23287 AFFECTED FILES processcore/C

D23287: Create a plugin framework for processes

2019-08-20 Thread David Edmundson
davidedmundson updated this revision to Diff 64136. davidedmundson added a comment. update REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64100&id=64136 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23287 AFFECTED FILE

D23287: Create a plugin framework for processes

2019-08-20 Thread David Edmundson
davidedmundson marked 7 inline comments as done. davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in extended_process_list.cpp:62 > Add `reserve` call I can't add a meaningful one. p->attributes() is itself another vector of size 0 to N. > broulik wrote in process_data_pro

D23287: Create a plugin framework for processes

2019-08-20 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > extended_process_list.cpp:62 > +{ > +QVector rc; > +for (auto p: qAsConst(d->m_providers)) { Add `reserve` call > extended_process_list.cpp:76 > +if (!factory) { > +return; > +} Shouldn't this be a `continue`?

D23287: Create a plugin framework for processes

2019-08-20 Thread David Edmundson
davidedmundson updated this revision to Diff 64100. davidedmundson added a comment. Update REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64097&id=64100 REVISION DETAIL https://phabricator.kde.org/D23287 AFFECTED FILES processcore/C

D23287: Create a plugin framework for processes

2019-08-20 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Currently everything for processes is hardcoded with a method for each proc