ahiemstra requested changes to this revision.
ahiemstra added a comment.
This revision now requires changes to proceed.
Just a few small things I came across when working on the network plugin.
INLINE COMMENTS
> extended_process_list.cpp:82
> + for (auto plugin: pluginObjects) {
> + auto factory = qobject_cast<KPluginFactory*>(plugin);
> + if (!factory) {
It would probably be nice to have some categorized logging here that reports
the loaded plugins. It would make it easier to figure out if/when your plugin
does not load.
> formatter.h:48
> + /**
> + * Returns the scale factor suitable for KSignalPlotter.
> + *
I don't think KSignalPlotter is very relevant here. :) (Also in the next
comment block.)
> process_data_provider.h:66
> + QString shortName() const;
> + void setShortName(const QString &name);
> +
I'm missing the implementation for this method in process_data_provider.cpp
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D23287
To: davidedmundson, #plasma, ahiemstra
Cc: ahiemstra, alexde, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
