This revision was automatically updated to reflect the committed changes.
Closed by commit R856:4356d9306990: Add browser action for status reporting
(authored by broulik).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D23126?vs=63707&id=64207#toc
REPOSITORY
R856 Plasma Browser Integra
ognarb accepted this revision.
ognarb added a comment.
This revision is now accepted and ready to land.
For the png problem it was because I had a navbar with the same color.
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D23126
To: broulik, #plasm
ognarb added a comment.
Tested in Firefox:
The PNG is not displayed.
I'm not a fan of using string as enum value (portStatus).
INLINE COMMENTS
> action_popup.css:22
> +
> +section {
> +padding: 1em;
Not used
> ognarb wrote in action_popup.css:32
> Why it is empty?
Or maybe ad
ognarb added a reviewer: ognarb.
ognarb added a comment.
I will provide more feedback tomorrow, when I have more time.
INLINE COMMENTS
> action_popup.css:32
> +
> +main {
> +
Why it is empty?
> action_popup.css:45
> +}
> +.message.error {
> +
same
REPOSITORY
R856 Plasma Browser Integrat
broulik updated this revision to Diff 63707.
broulik added a comment.
- Rebase
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D23126?vs=63659&id=63707
REVISION DETAIL
https://phabricator.kde.org/D23126
AFFECTED FILES
extension/_local
broulik created this revision.
broulik added reviewers: Plasma, VDG, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
This adds a tool bar icon for reporting extension status in lieu of the error
notifica
