broulik created this revision. broulik added reviewers: Plasma, VDG, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision.
REVISION SUMMARY This adds a tool bar icon for reporting extension status in lieu of the error notification. When the extension isn't supported or fails to start, the Plasma icon is crossed out. Especially when synced to a device without plasma-browser-integration, the error notification that used to show up can be annoying and misleading. When the extension crashes, an overlay is shown. Currently, the overlay is disabled when the extension is running properly, but additional controls such as sharing and media controls blacklist settings could be added to the browser action. This patch is mostly for the base infrastructure of such a toolbar icon. TEST PLAN Needs proper icon from VDG, cf. Bug 410821 Disabled icon F7235286: Screenshot_20190813_155423.png <https://phabricator.kde.org/F7235286> Explanation for not working F7235285: Screenshot_20190813_155400.png <https://phabricator.kde.org/F7235285> F7235287: Screenshot_20190813_155453.png <https://phabricator.kde.org/F7235287> Crashed icon F7235282: Screenshot_20190811_220957.png <https://phabricator.kde.org/F7235282> Crashed explanation F7235288: Screenshot_20190813_155517.png <https://phabricator.kde.org/F7235288> When the host crashes, you also get a DrKonqi dialog but don't think there's a way for us (other than matching the "Native host has exited" string) to tell whether it crashed (DrKonqi) or got disconnected for violating the communication protocol or just quit gracefully because of some other issue (No DrKonqi) All working F7235297: Screenshot_20190813_155854.png <https://phabricator.kde.org/F7235297> Chrome always shows an extension icon which has a default context menu, on Firefox the icon hides completely in this case. REPOSITORY R856 Plasma Browser Integration REVISION DETAIL https://phabricator.kde.org/D23126 AFFECTED FILES extension/_locales/en/messages.json extension/action_popup.css extension/action_popup.html extension/action_popup.js extension/constants.js extension/extension.js extension/icons/plasma-disabled-128.png extension/manifest.json To: broulik, #plasma, #vdg, fvogt Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
