D22323: Code cleanups

2019-07-08 Thread Tomaz Canabrava
This revision was automatically updated to reflect the committed changes. Closed by commit R871:1af8e1cc37e9: Const-correctness (authored by tcanabrava). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22323?vs=61325&id=61330#toc REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https

D22323: Code cleanups

2019-07-08 Thread Tomaz Canabrava
tcanabrava added a comment. In D22323#492220 , @sitter wrote: > I do wonder if it wouldn't make sense to make the two helpers into a new class DrKonqiLauncher or some such and then delegate this entire decision to the class. The way this was bef

D22323: Code cleanups

2019-07-08 Thread Harald Sitter
sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. I do wonder if it wouldn't make sense to make the two helpers into a new class DrKonqiLauncher or some such and then delegate this entire decision to the class. The way this was before the

D22323: Code cleanups

2019-07-08 Thread Tomaz Canabrava
tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY Send options as an Array *should* be faster as potentially there will be just one allocation Rename variable: QAppli