tcanabrava added a comment.
In D22323#492220 <https://phabricator.kde.org/D22323#492220>, @sitter wrote: > I do wonder if it wouldn't make sense to make the two helpers into a new class DrKonqiLauncher or some such and then delegate this entire decision to the class. The way this was before the diff is weird, and the way it is after the diff is still weird IMHO. Also the two objects that are allocated in the two methods aren't properly deleted anywhere it seems. I'll try to rework them in classes in a followup change. REPOSITORY R871 DrKonqi BRANCH codeCleanups REVISION DETAIL https://phabricator.kde.org/D22323 To: tcanabrava, sitter Cc: sitter, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
