nicolasfella updated this revision to Diff 64127.
nicolasfella added a comment.
- Comments
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22087?vs=60630&id=64127
BRANCH
arcpatch-D22087
REVISION DETAIL
https://phabricator.kde.org/D22087
AFFEC
nicolasfella marked 5 inline comments as done.
nicolasfella added inline comments.
INLINE COMMENTS
> apol wrote in dbusmenushortcut_p.cpp:60
> const &, also this should possibly be transformed into a splitRef.
Doesn't work trivially because of the token.replace() below
> apol wrote in chrome.cp
apol added a comment.
+1 overall
INLINE COMMENTS
> powermanagementengine.cpp:442
> uint unnamedBatteries = 0;
> -foreach (QString source, m_batterySources) {
> +for (QString source : qAsConst(m_batterySources)) {
> DataContainer *batteryDataContainer = containerForSource
nicolasfella added a comment.
Ping?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D22087
To: nicolasfella, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel,
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts
nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.
TEST PLAN
Did Plasma things
REPOSITORY
R120 Plasma Workspace
BRANCH
foreach
REVISION DETAIL
