nicolasfella marked 5 inline comments as done. nicolasfella added inline comments.
INLINE COMMENTS > apol wrote in dbusmenushortcut_p.cpp:60 > const &, also this should possibly be transformed into a splitRef. Doesn't work trivially because of the token.replace() below > apol wrote in chrome.cpp:54 > const&? Not trivially possible because of the 'new ProfileBookmarks(profile)' below > apol wrote in screenpool.cpp:174 > Iterating through keys isn't very optimal, I'd use iterators here. Agreed, but in another patch REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22087 To: nicolasfella, #plasma Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
