D20569: RFC: Use more compact OSD

2020-05-19 Thread Nathaniel Graham
ngraham commandeered this revision. ngraham added a reviewer: broulik. ngraham added a comment. Yoink. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: ngraham, #plasma, #vdg, broulik Cc: kori, Armstrong, alexde, achauvel, abetts, ngraham, davidedmu

D20569: RFC: Use more compact OSD

2020-04-28 Thread Nathaniel Graham
ngraham added a comment. Yeah, I'm in favor of revisiting this. Sorry I helped kill it with bikeshedding earlier. :( Personally I appreciate the conceptual elegance of re-using the notification pop-ups, and this gains configurability with respect to location on screen, but code-wise it'

D20569: RFC: Use more compact OSD

2020-04-28 Thread Mélanie Chauvel
achauvel added a comment. Several options were discussed here, and I have a few questions: Do we want to keep the current design? -- I don’t really understand why the OSD has to be so huge, because it contains so few information compared to a not

D20569: RFC: Use more compact OSD

2020-04-28 Thread Ítalo Silva
kori added a comment. Why was this abandoned? The arguments in favor of not changing are mostly on a personal level ignoring the complaints that the current big square behaviour affects usability (I went more in detail about this in another comment

D20569: RFC: Use more compact OSD

2020-04-15 Thread Filip Fila
filipf added a comment. I still like osds as notifications but I agree with @alexde, a vertical osd in the corner opposite (?) to where notifications spawn would be visually more pleasing than what is proposed in this patch and should even get in the way less. REPOSITORY R120 Plasma Works

D20569: RFC: Use more compact OSD

2020-04-14 Thread Armstrong
Armstrong added a comment. the solution that @broulik is the ideal. Simply reposition it to a location that is not the center of the screen. Please reconsider adding that. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: broulik, #plasma, #vdg Cc

D20569: RFC: Use more compact OSD

2020-04-14 Thread Nathaniel Graham
ngraham added a comment. https://bugs.kde.org/show_bug.cgi?id=344393 now has two duplicates. I would like to propose reconsidering this. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: broulik, #plasma, #vdg Cc: alexde, achauvel, abetts, ngraham,

D20569: RFC: Use more compact OSD

2019-12-22 Thread Nathaniel Graham
ngraham added a comment. Yeah a Phab task would probably be a good place for this. Another idea that's periodically come up is using the Notifications system to display these kinds of status messages, instead of a dedicated and different-looking OSD element. REPOSITORY R120 Plasma Wor

D20569: RFC: Use more compact OSD

2019-12-22 Thread Alex Debus
alexde added a comment. Since the most common problem that people have is "the OSD gets in the way when I change the volume while playing a video", how about only changing those OSD styles for the "volume" and "brightness" and leave the rest as it is with their characteristic appearance and

D20569: RFC: Use more compact OSD

2019-12-18 Thread Mélanie Chauvel
achauvel added a comment. The current design seems amazing, how hard would it be to put it as an option? Even it may be better to use the notification system in the long run, accepting this patch or a modified version of it would be better than to wait for a long time still. Also, most

D20569: RFC: Use more compact OSD

2019-06-28 Thread Nathaniel Graham
ngraham added a comment. Using notifications for the OSD is an interesting idea. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: broulik, #plasma, #vdg Cc: abetts, ngraham, davidedmundson, hein, Codezela, Fuchs, filipf, zzag, plasma-devel, LeGast0

D20569: RFC: Use more compact OSD

2019-06-27 Thread Filip Fila
filipf added a comment. I've been thinking about this OSD themes thing and I can't say I like it. I don't like the fact that you now need a different LnF to change them either, but to have another configurable theme thing seems like overkill. Although it's not without a solution without

D20569: RFC: Use more compact OSD

2019-04-15 Thread Andres Betts
abetts added a comment. I like the way that this is going. I also like the way that mobile does volume. Very understated. I think this is going the right direction. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: broulik, #plasma, #vdg Cc: abetts,

D20569: RFC: Use more compact OSD

2019-04-15 Thread Nathaniel Graham
ngraham added a comment. In D20569#450552 , @davidedmundson wrote: > There's *currently* no standalone category. If we create one, I could see that being an adequate solution, and then this could go there. REPOSITORY R120 Plasma Works

D20569: RFC: Use more compact OSD

2019-04-15 Thread David Edmundson
davidedmundson added a comment. > Umm, just took that from the old code. What's the alternative? I guess I can just do width then without taking into acount panels Can do. We're in a layer above panels so it's fine to overlap if it ever does come up. > I don't think store.kde.org is

D20569: RFC: Use more compact OSD

2019-04-15 Thread Nathaniel Graham
ngraham added a comment. In general I feel like I have to agree with Eike that this might reduce the visual distinctiveness of the system. I think the current square one has character, though I don't hate the proposed new one. However I'm not sure this design would actually solve the mos

D20569: RFC: Use more compact OSD

2019-04-15 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in OsdItem.qml:31 > Screen.desktopAvailableWidth is all screens. Do you mean that? > > --- > > Dialog should understand Layout attached properties of mainItem, so you can > write the slightly more semantic: > > Layout.max s

D20569: RFC: Use more compact OSD

2019-04-15 Thread David Edmundson
davidedmundson added a comment. I'd like us to get in the habbit of putting new designs of theme changes on the store before we change defaults. INLINE COMMENTS > OsdItem.qml:31 > > -PlasmaCore.IconItem { > -id: icon > - > -height: parent.height - Math.max(progressBar.h

D20569: RFC: Use more compact OSD

2019-04-15 Thread Eike Hein
hein added a comment. Personally I'm not a big fan. I think the square OSD has more character and visual flair. The change proposed here looks rather cramped and removes some identity from the system. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 T

D20569: RFC: Use more compact OSD

2019-04-15 Thread Christian
Fuchs added a comment. In D20569#450462 , @broulik wrote: > > No matter where you place it, given that you can e.g. press the volume button multiple times whilst notifications are incoming, placement will be tricky and, depending on how it is

D20569: RFC: Use more compact OSD

2019-04-15 Thread Kai Uwe Broulik
broulik added a comment. > Great i hope we can make notifications more compact too They will be, see D20266 , but that's not the point of this discussion REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: brou

D20569: RFC: Use more compact OSD

2019-04-15 Thread Hazem Salem
Codezela added a comment. Great i hope we can make notifications more compact too because its too big now REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: broulik, #plasma, #vdg Cc: Codezela, Fuchs, filipf, zzag, plasma-devel, jraleigh, GB_2, ragr

D20569: RFC: Use more compact OSD

2019-04-15 Thread Kai Uwe Broulik
broulik added a comment. > No matter where you place it, given that you can e.g. press the volume button multiple times whilst notifications are incoming, placement will be tricky and, depending on how it is solved, jumpy. With the new system shouldn't it be too bad. I can stick the OS

D20569: RFC: Use more compact OSD

2019-04-15 Thread Christian
Fuchs added a comment. I like the first, small but centered variant. But I can see how people might want it differently: most of the time I use my PC for work. I assume if you are watching movies on it, a centered design is more of a bother than a corner one, whilst for work the center o

D20569: RFC: Use more compact OSD

2019-04-15 Thread Filip Fila
filipf added a comment. +1 on making the OSD more efficient, I think it's the right direction to be going in. Looking at the positioning though, it feels a bit weird to have an elongated shape more or less in the center of the screen. What about the idea to have OSDs spawn as notificati

D20569: RFC: Use more compact OSD

2019-04-15 Thread Vlad Zagorodniy
zzag added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D20569 To: broulik, #plasma, #vdg Cc: zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20569: RFC: Use more compact OSD

2019-04-15 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY A frequent complaint over the years is the size of the OSD. It was tried to alleviate that by