broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in OsdItem.qml:31
> Screen.desktopAvailableWidth is all screens. Do you mean that?
> 
> ---
> 
> Dialog should understand Layout attached properties of mainItem, so you can 
> write the slightly more semantic:
> 
> Layout.max screen.width/2
> Layout.min: units * 15
> 
> Though it's Dialog, so who knows....

> Do you mean that?

Umm, just took that from the old code. What's the alternative? I guess I can 
just do `width` then without taking into acount panels

> Though it's Dialog, so who knows....

I tried that, it didn't work reliably :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20569

To: broulik, #plasma, #vdg
Cc: davidedmundson, hein, Codezela, Fuchs, filipf, zzag, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to