D20035: Set autofocus to child KPluginSelector on UI load

ngraham added a comment. Nice work, thanks. I'm looking forward to seeing your next patches! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20035 To: jayeshbhoot, #plasma, ngraham Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D20035: Set autofocus to child KPluginSelector on UI load

This revision was automatically updated to reflect the committed changes. Closed by commit R119:763c0cf117bc: Set autofocus to child KPluginSelector on UI load (authored by jayeshbhoot, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.or

D20035: Set autofocus to child KPluginSelector on UI load

jayeshbhoot added a comment. This is my first patch. So I will need someone to land it. INLINE COMMENTS > ngraham wrote in kcm.cpp:41 > Don't need to include `QTimer` anymore. Fixed > ngraham wrote in kcm.cpp:89 > I'm not thrilled about this workaround. Any chance you can figure out why >

D20035: Set autofocus to child KPluginSelector on UI load

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! Do you have commit access or do you need someone to land these patches for you? REPOSITORY R119 Plasma Desktop BRANCH fix/focus-searchbar-in-plasmasearch-kcm (branched from m

D20035: Set autofocus to child KPluginSelector on UI load

jayeshbhoot updated this revision to Diff 54855. jayeshbhoot added a comment. - Remove unused dependency REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20035?vs=54853&id=54855 BRANCH fix/focus-searchbar-in-plasmasearch-kcm (branched from master)

D20035: Set autofocus to child KPluginSelector on UI load

ngraham added inline comments. INLINE COMMENTS > kcm.cpp:41 > #include > +#include > Don't need to include `QTimer` anymore. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20035 To: jayeshbhoot, #plasma Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen,

D20035: Set autofocus to child KPluginSelector on UI load

jayeshbhoot updated this revision to Diff 54853. jayeshbhoot added a comment. - Fix autofocus on searchbar on UI load REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20035?vs=54744&id=54853 BRANCH fix/focus-searchbar-in-plasmasearch-kcm (branched f

D20035: Set autofocus to child KPluginSelector on UI load

ngraham added inline comments. INLINE COMMENTS > kcm.cpp:89 > +// m_pluginSelector->setFocus() did not work. I dont know why. > +QTimer::singleShot(0, m_pluginSelector, SLOT(setFocus())); > } I'm not thrilled about this workaround. Any chance you can figure out why `m_pluginSelector->s

D20035: Set autofocus to child KPluginSelector on UI load

jayeshbhoot added a comment. True. The description isn't quite clear. The 'sibling commit' is this: https://phabricator.kde.org/D20034. But at the time of `arc diff`, I didn't know how to link to it. So I just linked them both via the BUG tag. Let me know what to correct here. REPOSITORY

D20035: Set autofocus to child KPluginSelector on UI load

ngraham added a comment. Thanks for the patch! But what is the sibling commit? The description is not quite clear to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20035 To: jayeshbhoot, #plasma Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D20035: Set autofocus to child KPluginSelector on UI load

jayeshbhoot created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jayeshbhoot requested review of this revision. REVISION SUMMARY A sibling commit to this commit in frameworks/kcmutils passes down the focus to the searchbar in KPluginSelector. CCB