ngraham added inline comments.

INLINE COMMENTS

> kcm.cpp:89
> +    // m_pluginSelector->setFocus() did not work. I dont know why.
> +    QTimer::singleShot(0, m_pluginSelector, SLOT(setFocus()));
>  }

I'm not thrilled about this workaround. Any chance you can figure out why 
`m_pluginSelector->setFocus()` doesn't work all on its own?

Also, don't use first-person comments in code.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20035

To: jayeshbhoot, #plasma
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to