D18976: Improve Contextmenu

This revision was automatically updated to reflect the committed changes. Closed by commit R878:c893ab3d2281: Improve Contextmenu (authored by trmdi, committed by mvourlakos). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18976?vs=51613&id=51615 REVISION

D18976: Improve Contextmenu

trmdi updated this revision to Diff 51613. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18976?vs=51573&id=51613 REVISION DETAIL https://phabricator.kde.org/D18976 AFFECTED FILES containmentactions/contextmenu/menu.cpp To: trmdi, #latte_dock, mvourla

D18976: Improve Contextmenu

mvourlakos added a comment. In D18976#411537 , @trmdi wrote: > Oh, wait... > I've just seen it is disabled unexpectedly. Do you know why ? yes, it comes from the setVisible(false) I dont know why, this is why I wanted to add in there:

D18976: Improve Contextmenu

trmdi added a comment. Oh, wait... I've just seen it is disabled unexpectedly. Do you know why ? REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18976 To: trmdi, #latte_dock, mvourlakos Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesl

D18976: Improve Contextmenu

trmdi updated this revision to Diff 51573. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18976?vs=51563&id=51573 REVISION DETAIL https://phabricator.kde.org/D18976 AFFECTED FILES containmentactions/contextmenu/menu.cpp To: trmdi, #latte_dock Cc: mvou

D18976: Improve Contextmenu

mvourlakos added inline comments. INLINE COMMENTS > menu.cpp:85 > +m_configureAction->setVisible(!configuring); > +}); > + this bracket ident needs to be like the one from m_addWidgetsAction > menu.cpp:138 > > +m_configureAction->setText(i18nc("view settings window

D18976: Improve Contextmenu

trmdi created this revision. trmdi added a reviewer: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - Display Dock Settings/Panel Settings instead of View Settings - Hide View Settings when configur