mvourlakos added inline comments.
INLINE COMMENTS
> menu.cpp:85
> + m_configureAction->setVisible(!configuring);
> + });
> +
this bracket ident needs to be like the one from m_addWidgetsAction
> menu.cpp:138
>
> + m_configureAction->setText(i18nc("view settings window", viewType ==
> Latte::Types::DockView ? "Dock &Settings..." : "Panel &Settings..."));
> +
including this like this I think it will faile gettest or return false results
for translation strings, a clean approach can be:
QString settingsStr = ( viewType == Latte::Types::DockView ? i18nc("dock
settings window", "Dock &Settings...") : i18nc("panel settings window, "Panel
&Settings") );
m_configureAction->setText(settingsStr);
REPOSITORY
R878 Latte Dock
REVISION DETAIL
https://phabricator.kde.org/D18976
To: trmdi, #latte_dock
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
