D18717: improvements for global shortcuts

This revision was automatically updated to reflect the committed changes. Closed by commit R878:fede9feb2dd0: improvements for global shortcuts (authored by trmdi, committed by mvourlakos). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18717?vs=51015&id=51

D18717: improvements for global shortcuts

trmdi added a comment. In D18717#406296 , @mvourlakos wrote: > @trmdi would you like to commit it for you? > Can I use your fullname shown at: https://phabricator.kde.org/p/trmdi/ ? > and what is your email? Yes, I don't have the co

D18717: improvements for global shortcuts

mvourlakos accepted this revision. mvourlakos added a comment. This revision is now accepted and ready to land. @trmdi would you like to commit it for you? Can I use your fullname shown at: https://phabricator.kde.org/p/trmdi/ ? and what is your email? REPOSITORY R878 Latte Dock REVISIO

D18717: improvements for global shortcuts

trmdi marked an inline comment as done. trmdi added a comment. 1, please make a check that sortedViewsList returns count()>0 and if it doesnt it can return a nullptr -> done 2, your turn REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18717 To: trmdi, mvou

D18717: improvements for global shortcuts

trmdi updated this revision to Diff 51015. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18717?vs=50978&id=51015 REVISION DETAIL https://phabricator.kde.org/D18717 AFFECTED FILES app/layout/layout.cpp app/layout/layout.h app/shortcuts/globalshortc

D18717: improvements for global shortcuts

mvourlakos added inline comments. INLINE COMMENTS > globalshortcuts.cpp:810 > +{ > +return > sortedViewsList(m_corona->layoutManager()->currentLatteViews())[0]; > +} 1. this can create a crash when there are no views at all shown. please make a check that sortedViewsList returns **count()>

D18717: improvements for global shortcuts

trmdi updated this revision to Diff 50978. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18717?vs=50974&id=50978 REVISION DETAIL https://phabricator.kde.org/D18717 AFFECTED FILES app/layout/layout.cpp app/layout/layout.h app/shortcuts/globalshortc

D18717: improvements for global shortcuts

trmdi added a comment. In D18717#405084 , @mvourlakos wrote: > it looks and behave nice, lets see with Layout how it will look but I believe there will be no issues, > we are ok to commit if the property is moved to Layout I've moved

D18717: improvements for global shortcuts

trmdi updated this revision to Diff 50974. REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18717?vs=50814&id=50974 REVISION DETAIL https://phabricator.kde.org/D18717 AFFECTED FILES app/layout/layout.cpp app/layout/layout.h app/shortcuts/globalshortc

D18717: improvements for global shortcuts

mvourlakos added a comment. In D18717#404866 , @trmdi wrote: > In D18717#404861 , @mvourlakos wrote: > > > > > > What do you think? it looks and behave nice, lets see with Layout how it

D18717: improvements for global shortcuts

trmdi added a comment. In D18717#404861 , @mvourlakos wrote: > @trmdi can you confirm me the following for your code ? > > 1. When a layout is loaded for first time then "global shortcuts based on position" are applied based on Latte set pri

D18717: improvements for global shortcuts

mvourlakos added a comment. @trmdi can you confirm me the following for your code ? 1. When a layout is loaded for first time then "global shortcuts based on position" are applied based on Latte set priority for which view to be forwarded 2. When the user changed the isPreferredForShort

D18717: improvements for global shortcuts

trmdi created this revision. trmdi added a reviewer: mvourlakos. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY BUG: 403880 REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18717 AFF