mvourlakos added inline comments. INLINE COMMENTS
> globalshortcuts.cpp:810 > +{ > + return > sortedViewsList(m_corona->layoutManager()->currentLatteViews())[0]; > +} 1. this can create a crash when there are no views at all shown. please make a check that sortedViewsList returns **count()>0** and if it doesnt it can return a **nullptr** 2. the function **highestPriorityView** probably needs to be moved at layout and **sortedViewsList** at the same time but that can be a different commit after this commit has landed because the **sortedViewList** is used I think in more places at globalshortcuts REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D18717 To: trmdi, mvourlakos Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart