D18255: Improve up/down display for Monitor widgets

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:64045dbddc14: Improve up/down display for Monitor widgets (authored by ngraham). REPOSITORY R120 Plasma Workspace C

D18255: Improve up/down display for Monitor widgets

ngraham added a comment. Landing based on @davidedmundson's "ship it" for what's left (I think he's asleep right now and I'd like to get this in before we branch). Will submit further patches for other changes. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org

D18255: Improve up/down display for Monitor widgets

ngraham updated this revision to Diff 49582. ngraham added a comment. Revert unit formatting changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18255?vs=49554&id=49582 BRANCH improve-network-monitor-display (branched from master) REVISION D

D18255: Improve up/down display for Monitor widgets

davidedmundson added a comment. > I grabbed this code from plasma-nm, which does the same thing. Ok, cool. Ship that part. --- As for the other change. Right now it's in JDEC - you're porting to IEC. Both are valid. SI would be wrong, but that would be k not K. -

D18255: Improve up/down display for Monitor widgets

ngraham added a comment. Seems like the original change to use bits (D4551 ) was not super popular and generated bug reports (https://bugs.kde.org/show_bug.cgi?id=383019). If/when this lands, I'll look into making the unit configurable, since I can see the

D18255: Improve up/down display for Monitor widgets

ngraham updated this revision to Diff 49554. ngraham added a comment. B -> b (B is bytes, and this measures bits) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18255?vs=49553&id=49554 BRANCH improve-network-monitor-display (branched from master

D18255: Improve up/down display for Monitor widgets

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18255 To: ngraham, #plasma, #vdg Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18255: Improve up/down display for Monitor widgets

ngraham updated this revision to Diff 49553. ngraham added a comment. It's actually measuring bits REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18255?vs=49552&id=49553 BRANCH improve-network-monitor-display (branched from master) REVISION DET

D18255: Improve up/down display for Monitor widgets

ngraham updated this revision to Diff 49552. ngraham added a comment. Use the correct units (e.g. kibibytes instead of kilobytes) REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18255?vs=49492&id=49552 BRANCH improve-network-monitor-display (bran

D18255: Improve up/down display for Monitor widgets

ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in DoublePlotter.qml:105 > Can we assume a font has ⬆ characters? I grabbed this code from `plasma-nm`, which does the same thing. I haven't heard any complaints about that so I'm going to assume yes? REPOSITORY R120 Plasm

D18255: Improve up/down display for Monitor widgets

davidedmundson added inline comments. INLINE COMMENTS > DoublePlotter.qml:105 > nameLabel.text = plotter.sensorName > -speedLabel.text = formatData(data1) + " | " + > formatData(data2) > +speedLabel.text = i18n("⬇ %2 | color='%3'>⬆ %4", > +

D18255: Improve up/down display for Monitor widgets

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch improves the up/down display for the Monitor widgets, and most nodablt the Network