This revision was not accepted when it landed; it landed in state "Needs
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c2ea0afb5596: Fallback to in-process prompt if logout
prompt fails (authored by davidedmundson).
REPOSITORY
R120 P
davidedmundson added inline comments.
INLINE COMMENTS
> ngraham wrote in shutdown.cpp:229
> Shutdown -> Shut Down
>
> "Shutdown" is a noun ("The nuclear reactor is experiencing a shutdown!")
>
> "Shut Down" is an imperative command with a verb ("Shut down the nuclear
> reactor!"), which is how
ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> shutdown.cpp:229
> +//i18nd is used as this patch was backported to an LTS
> with stable translations
> +
> fallback
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.
Has a nice Windows 3.1 flair to it
REPOSITORY
R120 Plasma Workspace
BRANCH
logout_prompt
REVISION DETAIL
https://phabricator.kde.org/D15869
To: davidedmundson, #plasma, broulik
Cc
davidedmundson added a comment.
It was.The situation is now much much much better.
But kscreenlocker-greet is a different process, and we've definitely seen
that fallback prompt shown.
Also I don't like the way it was done. It was done as a conservative exact
1:1 mapping of the origina
broulik added a comment.
Wasn't the whole point of making the greeter binary out of process to cover
cases where there is a version mismatch after updates?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D15869
To: davidedmundson, #plasma
Cc: broulik, plasma
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
KSmserver is currently very heavily tied to the shutdown prompt dialog.
On
