volkov closed this revision.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D15289
To: volkov, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
volkov updated this revision to Diff 41045.
volkov added a comment.
revert change of actionTriggered's signature
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15289?vs=41043&id=41045
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org
broulik added inline comments.
INLINE COMMENTS
> ksysguardprocesslist.h:49
> */
> class Q_DECL_EXPORT KSysGuardProcessList : public QWidget
> {
That class is exported, so changing method signatures will be ABI-incompatible.
Not sure how many guarantees we give for libksysguard but I would s
volkov created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
volkov requested review of this revision.
REVISION SUMMARY
QSignalMapper is obsolete and the code with lambda is shorter and clearer.
REPOSITORY
R111 KSysguard Library
BRANCH
master
REVI
