broulik added inline comments.

INLINE COMMENTS

> ksysguardprocesslist.h:49
>   */
>  class Q_DECL_EXPORT KSysGuardProcessList : public QWidget
>  {

That class is exported, so changing method signatures will be ABI-incompatible. 
Not sure how many guarantees we give for libksysguard but I would still prefer 
to keep breakages to a minimum.

You could just keep the `qobject_cast`

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D15289

To: volkov, #plasma
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to