D13772: Add AppStream metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R106:daa9e0c1eb12: Add AppStream metadata (authored by ngraham). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13772?vs=36839&id=36974 REVISION DETAIL https://phab

D13772: Add AppStream metadata

ngraham added a comment. Thanks! @pino? REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D13772 To: ngraham, #plasma, apol, mak, pino Cc: pino, mak, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13772: Add AppStream metadata

ngraham added a comment. Are folks satisfied with this now? REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D13772 To: ngraham, #plasma, apol, mak, pino Cc: pino, mak, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ap

D13772: Add AppStream metadata

mak added a comment. In D13772#284459 , @ngraham wrote: > FWIW, @mak, `appstrealcli validate` doesn't like my launchable tag, though I can't see anything wrong with it. > > dev@dev-pc:~/repos/ksysguard$ (appstream-metadata) appstreamcli va

D13772: Add AppStream metadata

ngraham added a comment. FWIW, @mak, `appstrealcli validate` doesn't like my launchable tag, though I can't see anything wrong with it. dev@dev-pc:~/repos/ksysguard$ (appstream-metadata) appstreamcli validate gui/org.kde.ksysguard.appdata.xml W - org.kde.ksysguard.appdata.xml:org.

D13772: Add AppStream metadata

ngraham updated this revision to Diff 36839. ngraham marked 6 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13772?vs=36805&id=36839 BRANCH appstream-metadata (branched from mast

D13772: Add AppStream metadata

apol added inline comments. INLINE COMMENTS > org.kde.ksysguard.appdata.xml:15 > + https://userbase.kde.org/KSysGuard > + type="homepage">https://www.kde.org/applications/system/ksysguard > + `https://www.kde.org/donate.php?app=org.kde.ksysguard` REPOSITORY R106 KSysguard REVISION D

D13772: Add AppStream metadata

pino requested changes to this revision. pino added inline comments. INLINE COMMENTS > org.kde.ksysguard.appdata.xml:11 > +System Guard allows you to monitor information and statistics about > your system. > +In addition to monitoring the local system, it can connect to remote > systems

D13772: Add AppStream metadata

mak requested changes to this revision. mak added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > org.kde.ksysguard.appdata.xml:2 > + > + > + KSysGuard Nitpick: Use `desktop-application` > org.kde.ksysguard.appdata.xml:7 > + org.kde.ksysguard > + CC0-1.0 > +

D13772: Add AppStream metadata

ngraham created this revision. ngraham added reviewers: Plasma, apol. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Add AppStream Metadata for KSysGuard, since it's currently la

D13772: Add AppStream metadata

ngraham added a comment. Also, I'd appreciate it if someone could please check my choice of licenses; I'm not 100% sure that I chose the right ones. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D13772 To: ngraham, #plasma, apol Cc: plasma-devel, ragreen, Pitel,