mak requested changes to this revision. mak added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > org.kde.ksysguard.appdata.xml:2 > +<?xml version="1.0" encoding="utf-8"?> > +<component type="desktop"> > + <name>KSysGuard</name> Nitpick: Use `desktop-application` > org.kde.ksysguard.appdata.xml:7 > + <id>org.kde.ksysguard</id> > + <metadata_license>CC0-1.0</metadata_license> > + <project_license>GPL-2.0+</project_license> Maybe using `FSFAP` as license is better here, so the sources don't have to ship a copy of the CC0 license. > org.kde.ksysguard.appdata.xml:18 > + <screenshot type="default"> > + <image > type="source">https://www.kde.org/images/screenshots/ksysguard.png</image> > + <image > type="thumbnail">https://www.kde.org/images/screenshots/resized/ksysguard.png</image> Thumbnails are generally thrown away be the metadata extractor on the Linux distro side, so you can really drop the "type" property of the image tag here and just add the source image. > org.kde.ksysguard.appdata.xml:28 > + </mimetypes> > +</component> The component is missing a `launchable` tag: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-launchable The categories and mimetypes lists can be dropped, as those will be automatically extracted from the desktop-file mentioned in the launchable tag (if they are not dropped, the metainfo file will *override* the desktop file contents, which is likely not the desired behavior here) REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D13772 To: ngraham, #plasma, apol, mak Cc: mak, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
