D12091: HIG entry for On-demand pattern and swipe list item

fabianr closed this revision. REPOSITORY R985 KDE Human Interface Guidelines REVISION DETAIL https://phabricator.kde.org/D12091 To: fabianr, colomar, mart, #kirigami Cc: plasma-devel, ngraham, mvourlakos, romangg, hpereiradacosta, apol, davidedmundson, mart, hein, kamathraghavendra

D12091: HIG entry for On-demand pattern and swipe list item

colomar accepted this revision. colomar added a comment. Perfect! REPOSITORY R985 KDE Human Interface Guidelines BRANCH swipe REVISION DETAIL https://phabricator.kde.org/D12091 To: fabianr, colomar, mart, #kirigami Cc: plasma-devel, ngraham, mvourlakos, romangg, hpereiradacosta, apol,

D12091: HIG entry for On-demand pattern and swipe list item

fabianr updated this revision to Diff 34275. fabianr added a comment. - removed border around dolphin example in ondemand pattern REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12091?vs=34271&id=34275 BRANCH swipe REVISION DETAIL

D12091: HIG entry for On-demand pattern and swipe list item

fabianr updated this revision to Diff 34271. fabianr added a comment. - moved example image to the top in ondemand pattern REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12091?vs=33745&id=34271 BRANCH swipe REVISION DETAIL https

D12091: HIG entry for On-demand pattern and swipe list item

colomar added a comment. More concrete suggestion: Move the Dolphin screenshot to the top, next to the mobile screenshot. REPOSITORY R985 KDE Human Interface Guidelines BRANCH swipe REVISION DETAIL https://phabricator.kde.org/D12091 To: fabianr, colomar, mart, #kirigami Cc: plasma-de

D12091: HIG entry for On-demand pattern and swipe list item

colomar added a comment. Currently we have a screenshot of the nouseover in Dolphin in here, but screenshots for swipeListItem only in the corresponding page. That gives preference to the Dolphin pattern because lazy people will implement what they see first. Therefore there should either be

D12091: HIG entry for On-demand pattern and swipe list item

fabianr updated this revision to Diff 33745. fabianr added a comment. - Changed 'How to use' for on demand pattern to incorporate phab feedback REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12091?vs=33631&id=33745 BRANCH swipe RE

D12091: HIG entry for On-demand pattern and swipe list item

colomar added inline comments. INLINE COMMENTS > fabianr wrote in ondemand.rst:27 > My intention was to suggest switching to a navigation pattern like > "Master-Detail" or "Column-based navigation", so each item has its own > content page where more actions could easily be displayed. > > What

D12091: HIG entry for On-demand pattern and swipe list item

fabianr updated this revision to Diff 33631. fabianr added a comment. - Fixed typo REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12091?vs=33609&id=33631 BRANCH swipe REVISION DETAIL https://phabricator.kde.org/D12091 AFFECTED

D12091: HIG entry for On-demand pattern and swipe list item

fabianr marked an inline comment as done. fabianr added inline comments. INLINE COMMENTS > colomar wrote in ondemand.rst:27 > Since this is a command pattern, shouldn't this link to command patterns > instead of navigation patterns? My intention was to suggest switching to a navigation pattern

D12091: HIG entry for On-demand pattern and swipe list item

colomar added a comment. See inline comments. Otherwise it looks good! INLINE COMMENTS > ondemand.rst:27 > + on-demand controls. If you need more actions, choose a different > + :doc:`navigation pattern `. > +- Only use on-demand controls, if the actions are the same for each item. Sin

D12091: HIG entry for On-demand pattern and swipe list item

fabianr updated this revision to Diff 33609. fabianr added a comment. - Updated visuals for listview and folderview REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12091?vs=32867&id=33609 BRANCH swipe REVISION DETAIL https://phab

D12091: HIG entry for On-demand pattern and swipe list item

mart added a comment. ok for the text, the screenshots would need update: both of them at the moment are desktop, which is ok (i would add the mouse cursor) and one mobile is needed, provided here: Desktop, listview: F5833032: image.png Mobile,

D12091: HIG entry for On-demand pattern and swipe list item

fabianr added inline comments. INLINE COMMENTS > mart wrote in ondemand.rst:11 > maybe add a dolphin screenshot as well with the + on hover? (or folderview) There is a dolphin screenshot with the hover in the desktop section, (line 48+) REPOSITORY R985 KDE Human Interface Guidelines REVISION

D12091: HIG entry for On-demand pattern and swipe list item

fabianr updated this revision to Diff 32867. fabianr added a comment. - Merge branch 'master' into swipe - added a screenshot for a desktop swipelistitem, small formating change - Added png file REPOSITORY R985 KDE Human Interface Guidelines CHANGES SINCE LAST UPDATE https://phabricat

D12091: HIG entry for On-demand pattern and swipe list item

mart added a comment. this may be an example screenshot for kirigami F5811714: image.png REPOSITORY R985 KDE Human Interface Guidelines REVISION DETAIL https://phabricator.kde.org/D12091 To: fabianr, colomar, mart, #kirigami Cc: plasma-devel, ngra