D11333: introduce the function containmentGraphicsItemPreview

2018-03-15 Thread Marco Martin
mart updated this revision to Diff 29595. mart added a comment. approach with a model a possible approach is this: a model with all the activities that map to items, but i don't like this, because it's pretty much duplicating the activity model present in kactivities with a worse versi

D11333: introduce the function containmentGraphicsItemPreview

2018-03-15 Thread Marco Martin
mart added a comment. a possible approach is this: a model with all the activities that map to items, but i don't like this, because it's pretty much duplicating the activity model present in kactivities with a worse version. another approach i'll try shortly, is to just have a list pr

D11333: introduce the function containmentGraphicsItemPreview

2018-03-15 Thread Marco Martin
mart added inline comments. INLINE COMMENTS > davidedmundson wrote in desktopview.cpp:201 > In the main code path shellcorona is responsible for assigning containments > to desktopviews. > > In this code path DesktopView is extracting the relevant containments for > itself. > > That's super m

D11333: introduce the function containmentGraphicsItemPreview

2018-03-15 Thread Marco Martin
mart added a comment. In D11333#225797 , @davidedmundson wrote: > ShellCorona only creates the containment in currentActivityChanged, so this swiping stuff isn't going to work until you've first switched containment an existing way, then starte

D11333: introduce the function containmentGraphicsItemPreview

2018-03-14 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. ShellCorona only creates the containment in currentActivityChanged, so this swiping stuff isn't going to work until you've first switched containment an existing w

D11333: introduce the function containmentGraphicsItemPreview

2018-03-14 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY binded to the desktopview function containmentItemForActivity usable from