mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in desktopview.cpp:201
> In the main code path shellcorona is responsible for assigning containments 
> to desktopviews.
> 
> In this code path DesktopView is extracting the relevant containments for 
> itself.
> 
> That's super messy, please redesign.

shellcorona assigns what is actually the current one, which is conceptually 
another thing.
not sure how to go on the other direction..
perhaps the corona could assign as well as another property like 
"allcontainmentsForScreen" which is then.. a model which has activity id, name 
and pointer to containment?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11333

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to