ratijas added inline comments.
INLINE COMMENTS
> ApplicationHeader.qml:278
> +target: delegateLoader.page
> +Component.onDestruction: delegateLoader.sourceComponent
> = null
> +}
Component attached object is a very special type in QML. It
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:b95460a4f831: Fix warnings (authored by apol).
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10523?vs=27204&id=27243
REVISION DETAIL
https://phabricator.kde.org
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10523
To: apol, #kirigami, mart
Cc: mart, ngraham, plasma-devel, apol, davidedmundson, hein
ngraham added a comment.
Much better! I still get a few warnings though:
file:///usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/kirigami.2/ToolBarApplicationHeader.qml:49:
TypeError: Cannot read property of null
file:///usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/kirigami.2/ToolBarApplicat
apol created this revision.
apol added a reviewer: Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
Make sure the page header is destroyed with the page itself
Don't dup
