apol created this revision. apol added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision.
REVISION SUMMARY Make sure the page header is destroyed with the page itself Don't duplicate logic to fetch the lastItem from the pageStack Make sure we are not calling null items TEST PLAN manual testing on discover and kirgami gallery REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D10523 AFFECTED FILES src/controls/templates/ApplicationHeader.qml src/controls/templates/OverlayDrawer.qml src/controls/templates/OverlaySheet.qml To: apol, #kirigami Cc: plasma-devel, apol, davidedmundson, mart, hein