Re: Review Request: add Applet::init() in Containment::init()

2010-02-23 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3041/#review4261 --- Ship it! - Aaron On 2010-02-23 12:46:46, Vincenzo Di Massa wrote: >

Re: Review Request: add Applet::init() in Containment::init()

2010-02-23 Thread Aaron Seigo
> On 2010-02-23 15:12:20, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/containment.cpp, lines 150-153 > > <http://reviewboard.kde.org/r/3041/diff/1/?file=19854#file19854line150> > > > > Applet::init() should definitely be called in the if (!isContainmen

Re: Review Request: add Applet::init() in Containment::init()

2010-02-23 Thread Richard Dale
> On 2010-02-23 15:12:20, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/containment.cpp, lines 150-153 > > <http://reviewboard.kde.org/r/3041/diff/1/?file=19854#file19854line150> > > > > Applet::init() should definitely be called in the if (!isContainmen

Re: Review Request: add Applet::init() in Containment::init()

2010-02-23 Thread Aaron Seigo
ttp://reviewboard.kde.org/r/3041/#comment3774> Applet::init() should definitely be called in the if (!isContainment()) block, but Applet::init() does various things that aren't appropriate for Containment. the only useful part in Applet::init() would be the package object creation. i'd sug

Review Request: add Applet::init() in Containment::init()

2010-02-23 Thread Vincenzo Di Massa
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3041/ --- Review request for Plasma. Summary --- Can this be harmful? I think this co

Re: Applet::init()

2009-09-30 Thread David Baron
On Wednesday 30 September 2009 19:36:28 Aaron J. Seigo wrote: > On September 30, 2009, David Baron wrote: > > Do ALL of it in background threads. > > Just start, set busy if need be, and exit init(). > > When threads needed for applet functionality are done, reset busy and let > > it play. > > th

Re: Applet::init()

2009-09-30 Thread Aaron J. Seigo
On September 30, 2009, David Baron wrote: > Do ALL of it in background threads. > Just start, set busy if need be, and exit init(). > When threads needed for applet functionality are done, reset busy and let > it play. threaded is one possibility; another is to use async methods which many of our

Applet::init()

2009-09-30 Thread David Baron
Apparently, plasma will wait until all of these are done before displaying anything (correct me if I am wrong). So any applet that checks unmounted/unmountable media, unconnected network connections, loads large data sets, etc., will make plasma wait and wait unless ... Do ALL of it in backgrou